-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestion to specify megapixels instead of zoom #9
Comments
Hello @Autur ! I've been doing some work on dezoomify-rs lately, and you might find this new tool helpful.
For instance, you can run:
And it will download the largest zoom level that is under 10000 x 10000. |
It's fast! But where does it save to? Edit: I noticed it doesn't have much in the way of error handling I think. This link (https://artsandculture.google.com/asset/wildflower-painting-of-red-grevillea/wwEzEHEBAqxv4w) didn't play well with either tool on my PC. |
@kolt54321 Thank you for the test case. I will look into the issue. |
It's fixed |
Thanks! |
I fixed the problem on dezoomify as well: https://ophir.alwaysdata.net/dezoomify/dezoomify.html#https://artsandculture.google.com/asset/wildflower-painting-of-red-grevillea/wwEzEHEBAqxv4w |
@lovasoa I finally got a chance to try out the new dezoomify. I tried it on 62 google arts links that gapdecoder had previously failed to process and it only failed on 3 of them. That's an excellent success rate! I'm going to keep a record of all the failed links going forward and can provide them in the future in case they will be useful in improving the success rate. Thanks for all your work. |
Yes, please do provide the links! Open an issue on each project, and give the non-working links for the project |
@lovasoa I really appreciate your responsiveness to my previous suggestions. The new tool is a huge improvement :) Thank you. I humbly make just one more suggestion:
The issue is that zoom levels do not refer to consistent pixel dimensions. For some images, zoom 5 can mean 6000 x 4000 pixels, while for others it can mean 12,000 x 8000. This is annoying because the user has in mind the dimensions they want, but the zoom is only an imperfect indicator. So my suggestion is to also allow users specify the dimensions, and you can keep the zoom option too if you think it's useful. In terms of user input, I think it makes the most sense to specify megapixels in integers like 24 (i.e., 24 = 6000 x 4000), rather than the pixel length or width, since artwork can be long/narrow. The fallback option, if the user specifies a size that is NA, I hope, can be kept.
This size specification is implemented in Boquete's tool but I like gapdecoder better :)
https://github.com/Boquete/google-arts-crawler
The text was updated successfully, but these errors were encountered: