Fix issue 336 #337
Merged
Fix issue 336 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ups) This commit resolves Issue 336 by only allowing Rees 0-matrix semigroups over perm groups to belong to IsActingSemigroup, which was always the intention.
wilfwilson
requested changes
Jun 16, 2017
There was a problem hiding this comment.
Yes this is the change I would've made. However, you also need to update the documentation in section 6.1-1, so that it specifically says perm group. It currently says that:
...subsemigroups of regular Rees 0-matrix semigroups over groups...
are acting semigroups.
|
Good point |
The test takes 16s or more without this, which is not appropriate for the standard tests.
james-d-mitchell
force-pushed
the
fix-issue-336
branch
from
3df552b
to
de2613d
Compare
|
Fixed it |
wilfwilson
approved these changes
Jun 16, 2017
|
Tests pass, I'm happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue 336