Various changes related to documentation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated files should not be in the repository
- remove the htm/ dir each time, to ensure no stray generated files from previous runs remain - pass -i option to convert.pl, so only a single index file is generated - pass -u option instead of -t to convert.pl so that unicode characters are used in the generated HTML
olexandr-konovalov
approved these changes
Aug 2, 2019
Closed
|
@vendramin is this (and the two other PRs) OK to merge? If so, can you please do so? I have a few more changes to fix bugs ready, but they build on this PR, so it'd be easier if this PR could be merged first. |
olexandr-konovalov
approved these changes
Aug 12, 2019
|
@vendramin are you happy to merge this? |
|
This reduced test failures from 20 to 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master, the manual cannot actually be compiled, at least
make_docruns into an error for me. This PR fixes this, and a bunch of related things; it also adjusts manual examples, fixing various typos in them. Thetst/manual.tstfile is adjusted accordingly. This gets the number of test failures down, the remaining ones are due to actual bugs in this package. I also noticed that the functionNicholsDatumis used in some examples but is undocumented.