Fix PositionsProperty with from < 1

gap-system · Jan 3, 2018 · 2666f5a · 2666f5a
1 parent b803d4f
commit 2666f5a
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 4 deletions.
diff --git a/lib/list.gi b/lib/list.gi
@@ -1525,8 +1525,8 @@ InstallMethod( PositionProperty,
     function( list, func, from )
     local i;
 
-    if from < 1 then
-      from:= 1;
+    if from < 0 then
+      from:= 0;
     fi;
     for i in [ from+1 .. Length( list ) ] do
       if IsBound( list[i] ) then
@@ -1557,8 +1557,8 @@ InstallMethod( PositionProperty,
     function( list, func, from )
     local i;
 
-    if from < 1 then
-      from:= 1;
+    if from < 0 then
+      from:= 0;
     fi;
     for i in [ from+1 .. Length( list ) ] do
       if func( list[i] ) then

diff --git a/tst/testinstall/list.tst b/tst/testinstall/list.tst
@@ -209,5 +209,25 @@ gap> PositionsProperty( ll, ReturnTrue );
 gap> PositionsProperty( ll, IsInt );
 [ 1, 2, 3 ]
 
+# PositionProperty
+gap> ll := [ 1, , "s" ];;
+gap> PositionProperty( ll, ReturnTrue, 0);
+1
+gap> PositionProperty( ll, ReturnTrue, 1);
+3
+gap> PositionProperty( ll, IsInt, 0);
+1
+gap> PositionProperty( ll, IsInt, 1);
+fail
+gap> ll := [ 1, 2, 3 ];;
+gap> PositionProperty( ll, ReturnTrue, 0);
+1
+gap> PositionProperty( ll, ReturnTrue, 1);
+2
+gap> PositionProperty( ll, ReturnTrue, 2);
+3
+gap> PositionProperty( ll, ReturnTrue, 3);
+fail
+
 #
 gap> STOP_TEST("list.tst");