Fix tab completion on non-record component objects

gap-system · Sep 9, 2022 · 4b01ecd · 4b01ecd
1 parent 7ba252e
commit 4b01ecd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/dev/gaptest.expect b/dev/gaptest.expect
@@ -40,5 +40,16 @@ expect "data1  data2"
 send -- "1);\r"
 expect "true"
 
+# test tab completion for a non-record component object
+expect "gap> "
+send -- "g:=SmallGroup(6,1);;\r"
+expect "gap> "
+send -- "g.\t"
+send -- "1;;\r"
+expect "gap> "
+send -- "g!.S\t"
+expect "ize"
+send -- ";;\r"
+expect "gap> "
 
 exit
diff --git a/lib/cmdledit.g b/lib/cmdledit.g
@@ -990,8 +990,10 @@ GAPInfo.CommandLineEditFunctions.Functions.Completion := function(l)
     # the first two <TAB> hits try existing component names only first
     if cf.tabbang then
       searchlist := ShallowCopy(NamesOfComponents(cf.tabrec));
-    else
+    elif IsRecord(cf.tabrec) then
       searchlist := ShallowCopy(RecNames(cf.tabrec));
+    else
+      searchlist := [];
     fi;
     if cf.tabcount > 2 then
       Append(searchlist, ALL_RNAMES());