Skip to content

Commit

Permalink
ENHANCE: Allow perfect subgroups from library of perfect groups
Browse files Browse the repository at this point in the history
even if NoPrecomputedData option is set -- otherwise the calculation cannot
but fail.

This fixes #1822.
  • Loading branch information
hulpke committed Nov 1, 2017
1 parent 18077ee commit a4933f1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/grplatt.gi
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,7 @@ InstallGlobalFunction(LatticeViaRadical,function(arg)
pcgs:=ser[2];
ser:=ser[1];
if Index(G,ser[1])=1 then
Info(InfoWarning,1,"group is solvable");
Info(InfoWarning,3,"group is solvable");
hom:=NaturalHomomorphismByNormalSubgroup(G,G);
hom:=hom*IsomorphismFpGroup(Image(hom));
u:=[[G],[G],[hom]];
Expand Down Expand Up @@ -1373,7 +1373,9 @@ local badsizes,n,un,cl,r,i,l,u,bw,cnt,gens,go,imgs,bg,bi,emb,nu,k,j,
Length(ConjugacyClasses(G))," to consider");

if Length(un)>0 and ValueOption(NO_PRECOMPUTED_DATA_OPTION)=true then
Error("Cannot get perfect subgroups without data library!");
Info(InfoWarning,1,
"Using (despite option) data library of perfect groups, as the perfect\n",
"#I subgroups otherwise cannot be obtained!");
elif Length(un)>0 then
Info(InfoPerformance,2,"Using Perfect Groups Library");
fi;
Expand Down
2 changes: 2 additions & 0 deletions tst/testextra/grplatt.tst
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ gap> Length(MaximalSubgroupClassReps(g));
gap> Length(ConjugacyClassesSubgroups(SymmetricGroup(7)));
96
gap> Length(ConjugacyClassesSubgroups(SymmetricGroup(7):NoPrecomputedData));
#I Using (despite option) data library of perfect groups, as the perfect
#I subgroups otherwise cannot be obtained!
96

# thats all, folks
Expand Down

0 comments on commit a4933f1

Please sign in to comment.