Skip to content

Commit

Permalink
Fix unexpected error in ConjugacyClassesSubgroups
Browse files Browse the repository at this point in the history
This disables an attempt to use cyclic extension instead of lifting for
lattices of smallish groups. The issue is that CE returns data in a
slightly different format than required. This resulted in some commands,
e.g. `ConjugacyClassesSubgroups(SmallGroup(1344,11293))`, to enter a
break loop.

If tomlib is loded it's a mote issue, and thus does not merit further
investigation.

This resolves #4854
  • Loading branch information
hulpke authored and fingolfin committed Sep 9, 2022
1 parent a45db74 commit e2a206e
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
12 changes: 8 additions & 4 deletions lib/grplatt.gi
Original file line number Diff line number Diff line change
Expand Up @@ -845,11 +845,15 @@ InstallGlobalFunction(LatticeViaRadical,function(arg)
makesubgroupclasses,cefastersize;

#group order below which cyclic extension is usually faster
if IsPackageMarkedForLoading("tomlib","")=true then
# WORKAROUND: there is a disparity between the data format returned
# by CE and what this code expects. This could be resolved properly,
# but since most people will have tomlib loaded anyway, this doesn't
# seem worth the effort.
#if IsPackageMarkedForLoading("tomlib","")=true then
cefastersize:=1;
else
cefastersize:=40000;
fi;
#else
# cefastersize:=40000;
#fi;

makesubgroupclasses:=function(g,l)
local i,m,c;
Expand Down
5 changes: 5 additions & 0 deletions tst/testbugfix/2022-09-06-ConjugacyClassesSubgroups.tst
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# The following used to work in GAP 4.10, but was broken in GAP
# 4.11.x and also 4.12.0.
# See https://github.com/gap-system/gap/issues/4854
gap> Length(ConjugacyClassesSubgroups(SmallGroup(1344,11293)));
83

0 comments on commit e2a206e

Please sign in to comment.