Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problems with empty lists of generators #2104

Closed
ThomasBreuer opened this issue Jan 23, 2018 · 0 comments
Closed

problems with empty lists of generators #2104

ThomasBreuer opened this issue Jan 23, 2018 · 0 comments
Assignees
@hulpke
Labels
kind: bug Issues describing general bugs, and PRs fixing them regression A bug that only occurs in the branch, not in a release
Milestone
GAP 4.9.1

Comments

@ThomasBreuer
Copy link
Contributor

Currently the following happens in the master branch.

gap> IsNaturalGL( TrivialSubgroup( GL(2,2) ) );
Error, if no generators are given the dimension must be given explicitly at /.../gap/lib/meataxe.gi:37 called from
GModuleByMats( GeneratorsOfGroup( grp ), DefaultFieldOfMatrixGroup( grp ) 
 ) at /.../gap/lib/grpffmat.gi:94 called from
[...]

This problem is not present in released GAP versions.
Its reason seems to be commit 40d6617.
@fingolfin fingolfin added this to the GAP 4.9.1 milestone Jan 23, 2018
@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them regression A bug that only occurs in the branch, not in a release labels Jan 23, 2018
hulpke added a commit to hulpke/gap that referenced this issue Jan 23, 2018
@hulpke
FIX: Enforce that Natural(G/S)L test creates module with generators.
03975f3 
This fixes gap-system#2104
hulpke added a commit to hulpke/gap that referenced this issue Jan 23, 2018
@hulpke
FIX: Enforce that Natural(G/S)L test creates module with generators.
3bf17c9 
This fixes gap-system#2104
hulpke added a commit to hulpke/gap that referenced this issue Feb 1, 2018
@hulpke
FIX: Enforce that Natural(G/S)L test creates module with generators.
8763634 
This fixes gap-system#2104
@hulpke hulpke mentioned this issue Feb 1, 2018
Closed
fingolfin pushed a commit to fingolfin/gap that referenced this issue Feb 5, 2018
@hulpke @fingolfin
FIX: Enforce that Natural(G/S)L test creates module with generators.
335e2fe 
This fixes gap-system#2104
fingolfin pushed a commit to fingolfin/gap that referenced this issue Feb 7, 2018
@hulpke @fingolfin
FIX: Enforce that Natural(G/S)L test creates module with generators.
d151227 
This fixes gap-system#2104
fingolfin pushed a commit to fingolfin/gap that referenced this issue Feb 8, 2018
@hulpke @fingolfin
FIX: Enforce that Natural(G/S)L test creates module with generators.
1e2eccd 
This fixes gap-system#2104
fingolfin pushed a commit to fingolfin/gap that referenced this issue Mar 7, 2018
@hulpke @fingolfin
FIX: Enforce that Natural(G/S)L test creates module with generators.
22c725c 
This fixes gap-system#2104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hulpke hulpke

Labels
kind: bug Issues describing general bugs, and PRs fixing them regression A bug that only occurs in the branch, not in a release
Projects
None yet
Milestone
GAP 4.9.1
Development

No branches or pull requests
3 participants
@fingolfin @hulpke @ThomasBreuer