Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate instance of RealExecStatFuncs #495

Closed
dimpase opened this issue Jan 19, 2016 · 3 comments
Closed

duplicate instance of RealExecStatFuncs #495

dimpase opened this issue Jan 19, 2016 · 3 comments
Labels
gapsagedays2016 Issues and PRs that arose at https://www.gapdays.de/gap-sage-days2016 kind: bug Issues describing general bugs, and PRs fixing them

Comments

@dimpase
Copy link
Member

dimpase commented Jan 19, 2016

RealExecStatFuncs is declared in profile.c and in stats.c
In both places it is declared as

        UInt (* RealExecStatFuncs[256]) ( Stat stat );

looks like a bug to me.
@dimpase dimpase added the kind: bug Issues describing general bugs, and PRs fixing them label Jan 19, 2016
@ChrisJefferson
Copy link
Contributor

Good catch!

One of these variables should be renamed -- they are doing entirely different things, just two different people (one of them me) decided to name their copy of ExecStatFuncs as RealExecStatFuncs.

@dimpase
Copy link
Member Author

dimpase commented Jan 19, 2016

discovered while attempting to build libGAP on OSX, see http://trac.sagemath.org/ticket/19911

@ChrisJefferson ChrisJefferson mentioned this issue Jan 19, 2016
Merged
@olexandr-konovalov olexandr-konovalov added the gapsagedays2016 Issues and PRs that arose at https://www.gapdays.de/gap-sage-days2016 label Jan 19, 2016
@olexandr-konovalov
Copy link
Member

Fixed in the master branch in #496 by @ChrisJefferson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gapsagedays2016 Issues and PRs that arose at https://www.gapdays.de/gap-sage-days2016 kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ChrisJefferson @dimpase @olexandr-konovalov