Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filename/location info to ApplicableMethod #1058

Merged
merged 2 commits into from
Jan 9, 2017

Conversation

ChrisJefferson
Copy link
Contributor

Make ApplicableMethod show filename / location information.

Also add LocationFunc, a simple method to get filename:linenumber information for a function.

There are no tests, as they would inevitably have the current directory of GAP in.

@codecov-io
Copy link

Current coverage is 50.41% (diff: 8.33%)

Merging #1058 into master will decrease coverage by <.01%

@@             master      #1058   diff @@
==========================================
  Files           424        424          
  Lines        223027     223048    +21   
  Methods        3429       3429          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits         112453     112454     +1   
- Misses       110574     110594    +20   
  Partials          0          0          

Powered by Codecov. Last update 14b7135...7eeec2f

@hulpke
Copy link
Contributor

hulpke commented Jan 8, 2017

Nice!

@markuspf markuspf merged commit 478f4ef into gap-system:master Jan 9, 2017
@frankluebeck
Copy link
Member

"In principle" nice!
But this produces many overlong lines because of the full paths. This makes the output difficult to read.

How about printing only the paths relative to the GAP root? (Similar to BrowseGapMethods from where you can also inspect the code.)

@ChrisJefferson
Copy link
Contributor Author

In general, we could use shorter filenames in several places (such as in backtraces). There was a previous discussion on this and various people wanted the complete filename, even when it is under GAPROOT.

@ChrisJefferson ChrisJefferson deleted the applicablemethod branch February 5, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants