Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating random permutations using a random source #1165

Merged
merged 1 commit into from
Feb 25, 2017

Conversation

fingolfin
Copy link
Member

This is an alternate of PR #573, but making use of InstallMethodWithRandomSource.

@codecov
Copy link

codecov bot commented Feb 23, 2017

Codecov Report

Merging #1165 into master will increase coverage by 9.89%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
+ Coverage   58.46%   68.35%   +9.89%     
==========================================
  Files         434      435       +1     
  Lines      230449   230662     +213     
==========================================
+ Hits       134722   157677   +22955     
+ Misses      95727    72985   -22742
Impacted Files Coverage Δ
lib/gpprmsya.gi 53.03% <100%> (+4.95%)
lib/factgrp.gi 82.64% <ø> (-0.73%)
src/saveload.c 62.97% <ø> (-0.66%)
src/gmpints.c 93.81% <ø> (-0.26%)
src/dt.c 1.82% <ø> (-0.01%)
src/objects.h 100% <ø> (ø)
lib/teachmod.g 12.94% <ø> (ø)
src/trans.c 99.8% <ø> (+0.03%)
lib/package.gi 36.56% <ø> (+0.08%)
lib/ctblmono.gi 62.63% <ø> (+0.09%)
... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413dc3e...2e5bca7. Read the comment docs.

@stevelinton
Copy link
Contributor

Looks good to me

@ChrisJefferson
Copy link
Contributor

This looks fine. You could pop something like:

gap> randomTest(SymmetricGroup(2), Random);
gap> randomTest(SymmetricGroup(3), Random);
gap> randomTest(SymmetricGroup(4), Random);
gap> randomTest(AlternatingGroup(3), Random);
gap> randomTest(AlternatingGroup(4), Random);
gap> randomTest(AlternatingGroup(5), Random);

To the end of testinstall/random.tst (or I can do that later). The tests pass.

Copy link
Member

@markuspf markuspf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the tests mentioned by @ChrisJefferson this looks good to me, too.

Also add some tests for Random on natural symmetric and alternating groups
@fingolfin
Copy link
Member Author

Rebased and added some tests, let's see how that works out.

@ChrisJefferson ChrisJefferson merged commit ee504a1 into gap-system:master Feb 25, 2017
@fingolfin fingolfin deleted the mh/floyd branch February 27, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants