Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the timeout code #1324

Merged
merged 1 commit into from
Jun 11, 2017
Merged

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented May 9, 2017

It suffers from fundamental problems which seem unlikely to be resolved.
See also issues #664, #695, #765.

This should not be merged without discussion on the mailing list: After all, it removes a feature that was documented in a previous release. The only reason I am considering doing so at all is that I hope the feature is obscure enough that most people won't notice anyway.

@fingolfin fingolfin added the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label May 9, 2017
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone May 10, 2017
@fingolfin fingolfin removed the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label May 16, 2017
@codecov
Copy link

codecov bot commented May 19, 2017

Codecov Report

Merging #1324 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
- Coverage   62.64%   62.64%   -0.01%     
==========================================
  Files        1015     1014       -1     
  Lines      342624   342352     -272     
  Branches    14218    14182      -36     
==========================================
- Hits       214622   214450     -172     
+ Misses     124855   124782      -73     
+ Partials     3147     3120      -27
Impacted Files Coverage Δ
hpcgap/lib/system.g 65.75% <ø> (ø) ⬆️
src/gap.c 55.06% <ø> (+1.46%) ⬆️
hpcgap/lib/error.g 37.63% <ø> (+0.26%) ⬆️
hpcgap/src/stats.c 69.15% <ø> (+0.61%) ⬆️
lib/system.g 66.97% <ø> (ø) ⬆️
src/stats.c 72.74% <ø> (-3.35%) ⬇️
src/sysfiles.c 30.53% <ø> (ø) ⬆️
lib/function.gi 72.72% <ø> (+14.58%) ⬆️
lib/error.g 35.79% <ø> (+0.23%) ⬆️
lib/kernel.g 65.07% <0%> (-15.88%) ⬇️
... and 8 more

@fingolfin
Copy link
Member Author

The AppVeyor failure was due to a hack we had in place that removed timeout.tst on windows -- and since this PR removes timeout.tst as well, that hack lead to an error. Which should now be resolved.

Also rebased this.

@markuspf
Copy link
Member

Also note that @ChrisJefferson provided a well-working alternative for most use-cases based on IO_fork, available over here gap-packages/io#47 (but seems to need some love)

It had fundamental problems which seem unlikely to be resolved.
See also issues gap-system#664, gap-system#695, gap-system#765.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants