Remove SuPeRfail and READ_COMMAND

[markuspf]

See #560. Its time has come.

[olexandr-konovalov]

Hm, the latest SgpViz version that is picked up for the redistribution is 0.998 of 31/05/2008. Was the new one released today?

[codecov]

Codecov Report

Merging #1374 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
+ Coverage   63.11%   63.11%   +<.01%     
==========================================
  Files         970      970              
  Lines      291996   291984      -12     
  Branches    12743    12718      -25     
==========================================
- Hits       184294   184287       -7     
+ Misses     104906   104897       -9     
- Partials     2796     2800       +4

Impacted Files	Coverage Δ
src/bool.c	93.81% <ø> (+1.65%)	⬆️
src/hpc/serialize.c	8.08% <ø> (+0.05%)	⬆️
src/streams.c	47.39% <ø> (+0.22%)	⬆️
src/hpc/thread.c	45.65% <0%> (-0.6%)	⬇️
src/hpc/threadapi.c	33.92% <0%> (-0.29%)	⬇️
src/stats.c	79.01% <0%> (-0.28%)	⬇️
src/funcs.c	74.61% <0%> (ø)	⬆️
src/gap.c	60.37% <0%> (+0.08%)	⬆️
src/objset.c	82.59% <0%> (+0.23%)	⬆️
hpcgap/lib/hpc/stdtasks.g	38.87% <0%> (+0.25%)	⬆️
... and 1 more

[fingolfin]

As far as I can tell, the SgpViz still uses SuPeRfail

[markuspf]

What changes does this PR require?

[fingolfin]

This PR needlessly breaks compatibility with a package we currently distribute.

[fingolfin]

Manuel Delgado, one of the authors of sgpviz, will be at the upcoming GAP Days in Siegen, and I talked with him about preparing a new release of his package there. Assuming that works out, we can probably merge this PR (after it has been rebased)

[olexandr-konovalov]

@ManuelAFDelgado removed SuPeRfail in gap-packages/sgpviz@fd16cad - now waiting for this to appear in the next release.

[fingolfin]

This PR also needs to be rebased

[markuspf]

I have rebased it now.

[markuspf]

Also fixed the hpc/serialize.c code that made the tests for HPC-GAP fail now, rebased again.

[fingolfin]

The FR and ZeroMQInterface packages still use READ_COMMAND. See gap-packages/fr#23 and gap-packages/ZeroMQInterface#12

[olexandr-konovalov]

Resolved in ZeroMQ, but not yet in FR. @laurentbartholdi would you mind merging gap-packages/fr#23 and making a new release of FR, please?

[markuspf]

Rebased again...

[olexandr-konovalov]

Thanks to @laurentbartholdi - FR package is released and picked up for the redistribution. Now subject to passing tests, this PR may be merged as soon as the new FR release will appear in the packages-master.tar.gz archive.

[fingolfin]

Awesome! Perhaps @laurentbartholdi would also consider looking at the four open PRs for float and merging these, followed by a release? :-)

[laurentbartholdi]

Dear Max: I saw your PR for float (sorry I had missed them), and all are fine except the "remove extern dependencies". I personally very much prefer packages *not* to download and install external dependencies, and I reluctantly put that code in. However, once I tried to remove it, and got complaints from users who didn't want to do manual installs. Indeed it seems that half the people are upset by each of the methods. I definitely agree with you that it shouldn't be necessary to have all the packages. I'll see into that. Best, Laurent

[fingolfin]

@laurentbartholdi fair enough. I posted your remark to the relevant PR, gap-packages/float#27 and also added some replies; perhaps we can discuss there?

[olexandr-konovalov]

As https://github.com/gap-system/gap/wiki/Package-updates-status shows, new Float and FR has been picked up. They are now contained in packages-master.tar.gz. This can be now merged. @fingolfin requested changes - please update your review and merge then!