Performance improvements to maximal and intermediate subgroups, fix of RepresentativeAction #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1390 +/- ##
==========================================
+ Coverage 64.17% 64.21% +0.03%
==========================================
Files 990 990
Lines 321773 321855 +82
Branches 13063 13065 +2
==========================================
+ Hits 206503 206665 +162
+ Misses 112453 112373 -80
Partials 2817 2817
|
hulpke
added
kind: enhancement
|
Nice. So, just to clarify: Do you want a review (and then somebody else to merge it), or is this another of your branches that gradually gets changed until you merge it yourself? |
|
@fingolfin |
hulpke
added
kind: bug
Also add radical method for Sn/An also correct manual examples (b/c of other maxsub routine)
Restrict maximals by orbit length, keep conjugacy info, Always fall back on special Sbn/An maxes code, transfer radical from factor
Ensure that the correct domain is used if it is not the group on [1..n] but another domain. This fixes gap-system#1388
as integer, not as string.
olexandr-konovalov
changed the title
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improvements to maximal and intermediate subgroups (in part by ensuring special methods are used),
Fix of RepresentativeAction for Sn/An on nonstandard domain, preimages under projective actions.