Various changes, including fixes for CallFuncList #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
ChrisJefferson
approved these changes
Jun 13, 2017
Codecov Report
@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
+ Coverage 63.42% 63.45% +0.02%
==========================================
Files 1011 1011
Lines 339073 339078 +5
Branches 13761 13748 -13
==========================================
+ Hits 215068 215161 +93
+ Misses 120961 120887 -74
+ Partials 3044 3030 -14
|
This is a feature that to the best of my knowledge nobody uses, but which allows turning arbitrary GAP objects into something like a function; this feature was added by Steve 2010-09-19. This was broken in (at least) three ways, as uncovered by the test I wrote for this feature: 1. Calling such a function object with more than 6 arguments segfaulted; 2. Executed function calls with 3 arguments ignored the last 2 arguments; 3. Executed procedure calls with 5 arguments were rejected All three issues are fixed by this commit
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.