Change BlownUpMat to return fail for certain invalid inputs #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, return fail if Coefficients() returns fail. Fixes gap-system#826
|
@hulpke does this look reasonable to you? |
Codecov Report
@@ Coverage Diff @@
## master #1488 +/- ##
==========================================
+ Coverage 62.83% 64.19% +1.35%
==========================================
Files 991 992 +1
Lines 321285 322171 +886
Branches 13070 13078 +8
==========================================
+ Hits 201884 206803 +4919
+ Misses 116113 112550 -3563
+ Partials 3288 2818 -470
|
ChrisJefferson
approved these changes
Jul 12, 2017
markuspf
approved these changes
Jul 17, 2017
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, return fail if Coefficients() returns fail.
Fixes #826