Fix issue 395 #1492
Merged
Fix issue 395 #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves Issue 395 by installing a working method for DClassOfLClass, DClassOfRClass, and DClassOfHClass.
Codecov Report
@@ Coverage Diff @@
## master #1492 +/- ##
==========================================
+ Coverage 64.18% 64.19% +<.01%
==========================================
Files 992 992
Lines 322200 322198 -2
Branches 13096 13096
==========================================
+ Hits 206814 206837 +23
+ Misses 112564 112544 -20
+ Partials 2822 2817 -5
|
fingolfin
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves Issue #395 by installing a working method for
DClassOfLClass,DClassOfRClass, andDClassOfHClass, which previously ended in a recursion depth trap. The new methods are more robust and simpler than the previous ones.