Fix DoImmutableMatrix for finite fields (revised) #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoImmutableMatrix wrongly assumed that finite fields of order q <= 256 are represented as GF(q) and applied the NC versions of ConvertToMatrixRep to matrices over such fields which produced corrupted objects. E.g.: gap> f1 := AlgebraicExtension(GF(3), CyclotomicPolynomial(GF(3), 5));; gap> a := RootOfDefiningPolynomial(f1);; gap> mat := [[a]];; gap> DoImmutableMatrix(f1, mat, false); < immutable compressed matrix 1x393286524 over GF(26) >
A previous commit added a check for IsFFECollection(field) (which was suggested by me), but that is not actually correct, as "field" can also be an integer. Instead, check IsFFECollColl(matrix). Also fix a typo, change tabs to spaces, and refactor the code a little bit. And finally, add more systematic tests for ImmutableMatrix
fingolfin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
+ Coverage 64.17% 64.18% +<.01%
==========================================
Files 992 992
Lines 322141 322139 -2
Branches 13087 13092 +5
==========================================
+ Hits 206749 206765 +16
+ Misses 112570 112562 -8
+ Partials 2822 2812 -10
|
fingolfin
added
the
kind: bug
markuspf
approved these changes
Jul 17, 2017
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces PR #1481. It contains all the changes of that, but also