Fix RandomUnimodularMat (revised) #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it goes in an infinite loop.
Since the vectors here are in characteristic 0, ConvertToVectorRepNC does not do anything anyway.
fingolfin
added
the
kind: bug
fingolfin
changed the title
fingolfin
force-pushed
the
mh/fix-RandomUnimodularMat
branch
from
7789146
to
14d7384
Compare
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
==========================================
+ Coverage 64.18% 64.2% +0.01%
==========================================
Files 992 992
Lines 322108 322470 +362
Branches 13087 13161 +74
==========================================
+ Hits 206755 207036 +281
- Misses 112537 112588 +51
- Partials 2816 2846 +30
|
markuspf
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains PR #1508 by @wagh but also adds a test file, adds input validation to RandomUnimodularMat, and some other minor tweaks.