Add String method for functions #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Aug 17, 2017
lib/function.gi
Outdated
| @@ -59,3 +59,16 @@ function(func) | |||
| Append(result, " ) ... end"); | |||
| return result; | |||
| end); | |||
|
|
|||
|
|
|||
| InstallMethod(String, "for a function, using string stream", [IsFunction] , | |||
lib/function.gi
Outdated
| function(fun) | ||
| local s, str; | ||
| s := ""; | ||
| str := OutputTextString(s,true); |
lib/function.gi
Outdated
|
|
||
|
|
||
| InstallMethod(String, "for a function, using string stream", [IsFunction] , | ||
| function(fun) |
Codecov Report
@@ Coverage Diff @@
## master #1591 +/- ##
==========================================
- Coverage 63.98% 63.97% -0.01%
==========================================
Files 995 995
Lines 325334 325344 +10
Branches 13032 13032
==========================================
- Hits 208155 208148 -7
- Misses 114381 114394 +13
- Partials 2798 2802 +4
|
stevelinton
force-pushed
the
string-functions
branch
from
69f3813
to
6886e13
Compare
|
@fingolfin I've addressed your comments. I've also made the original method a method for DisplayString. The String method now returns a version with normalised whitespace, which is |
fingolfin
reviewed
Aug 18, 2017
lib/function.gi
Outdated
| str := OutputTextString(s, true); | ||
| PrintTo(str, fun); | ||
| CloseStream(str); | ||
| Add(s,'\n'); |
fingolfin
approved these changes
Aug 18, 2017
lib/function.gi
Outdated
| s := ""; | ||
| str := OutputTextString(s, true); | ||
| PrintTo(str, fun); | ||
| CloseStream(str); |
There was a problem hiding this comment.
Super-nitpick, I am not expecting any action on it, but needed to get it off my chest: When I see "str" I think "string", but here it is "stream", while "s" is a string... This function is short, and so it's harmless, but I'd still rename at least one of them (probably str to stream, as I see strings more more often than streams, at least in GAP code)
A bit of a hack as it uses string streams rather than modifying the kernel Includes tests
stevelinton
force-pushed
the
string-functions
branch
from
6886e13
to
2ef363d
Compare
|
Fixed nitpicks. Just wait for the tests to make sure I didn't break something. |
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a hack as it uses string streams rather than modifying the kernel