semirel: add family check to GreensXClassOfElement #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a check that the family of the object and the elements family of the family of the semigroup passed to the methods GreensXClassOfElement, where X in [R, L, H, D, J], are equal. This prevents the creation of Green's classes with wholly the wrong type of objects as representatives.
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
+ Coverage 61.7% 61.7% +<.01%
==========================================
Files 970 970
Lines 295733 295732 -1
Branches 13041 13041
==========================================
+ Hits 182475 182480 +5
+ Misses 110613 110609 -4
+ Partials 2645 2643 -2
|
olexandr-konovalov
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a check that the family of the object and the elements
family of the family of the semigroup passed to the methods
GreensXClassOfElement, where X in [R, L, H, D, J], are equal. This
prevents the creation of Green's classes with wholly the wrong type of
objects as representatives.