Fix IsomorphismPartialPermSemigroup and Monoid for perm groups with 0 generators #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these methods encountered unexpected errors for perm groups with 0 generators. This adds a special case for such groups. Resolves gap-system#1783
wilfwilson
added
kind: bug
fingolfin
approved these changes
Oct 19, 2017
There was a problem hiding this comment.
I cannot judge whether this is the "desired" or "expected" thing to do, but I guess @james-d-mitchell will comment on that.
Other than that, this PR looks plausible and sane.
Codecov Report
@@ Coverage Diff @@
## master #1784 +/- ##
==========================================
+ Coverage 62.83% 62.83% +<.01%
==========================================
Files 969 969
Lines 295262 295267 +5
Branches 13055 13055
==========================================
+ Hits 185516 185530 +14
+ Misses 106943 106936 -7
+ Partials 2803 2801 -2
|
|
Looks good to me too. |
|
@james-d-mitchell please use "rebase" and not a merge (or if you use a merge, at least adjust the merge commit message; the first line should be meaningful (i.e. tell what the merge added) even on the command line, which "Merge pull request #1784 from wilfwilson/fix-1783" is not |
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1783. Previously, these methods encountered unexpected errors for perm groups with 0 generators. This adds a special case for such groups.