Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when exterior power is 0-dimensional #1872

Merged
merged 2 commits into from
Nov 8, 2017

Conversation

laurentbartholdi
Copy link
Contributor

There's a bug with ExteriorPower:

gap> wedge := ExteriorPower(Rationals^10,11);;
gap> Dimension(wedge);
1

when it should be 0.

@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #1872 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1872      +/-   ##
==========================================
+ Coverage   63.49%   63.49%   +<.01%     
==========================================
  Files         952      952              
  Lines      286804   286803       -1     
  Branches    12722    12722              
==========================================
+ Hits       182103   182106       +3     
- Misses     101899   101900       +1     
+ Partials     2802     2797       -5
Impacted Files Coverage Δ
lib/algrep.gi 57.09% <100%> (+0.06%) ⬆️
src/iostream.c 46.24% <0%> (-0.4%) ⬇️
src/objset.c 82.36% <0%> (-0.24%) ⬇️
src/hpc/traverse.c 78.29% <0%> (-0.09%) ⬇️
src/funcs.c 74.75% <0%> (ø) ⬆️
src/hpc/threadapi.c 34.3% <0%> (+0.09%) ⬆️
src/lists.c 56.71% <0%> (+0.11%) ⬆️
src/stats.c 79.15% <0%> (+0.13%) ⬆️
src/hpc/thread.c 45.84% <0%> (+0.39%) ⬆️

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks sensible, but could you please add a test case (in a .tst file) for the bug? E.g. the one you describe in the PR

@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Nov 8, 2017
@fingolfin fingolfin merged commit 0c90c76 into gap-system:master Nov 8, 2017
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants