Fix inefficiency when dealing with certain algebra modules #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR is against |
fingolfin
force-pushed
the
mh/IsMonomialElementVectorSpace
branch
from
aa2e060
to
afc698a
Compare
Codecov Report
@@ Coverage Diff @@
## stable-4.9 #2058 +/- ##
==============================================
+ Coverage 67.01% 67.05% +0.04%
==============================================
Files 899 899
Lines 273517 273534 +17
==============================================
+ Hits 183307 183430 +123
+ Misses 90210 90104 -106
|
fingolfin
force-pushed
the
mh/IsMonomialElementVectorSpace
branch
2 times, most recently
from
5c9737d
to
18e748e
Compare
The issue was originally reported by Rudolf Tange on the GAP support mailing list. The fix is virtually identical to a fix for a similar issue, see 7aec45f
Reported by Rudolf Tange
Reported by Rudolf Tange
fingolfin
force-pushed
the
mh/IsMonomialElementVectorSpace
branch
from
18e748e
to
dfb8827
Compare
stevelinton
approved these changes
Jan 10, 2018
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was originally reported by Rudolf Tange on the GAP support mailing list. The fix is virtually identical to a fix for a similar issue, see 7aec45f