Turn IsInfiniteAbelianizationGroup into a property #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some implications for it, e.g. finite groups never have infinite abelianization; all but trivial free groups do have infinite abelianization). Finally, add some tests.
fingolfin
force-pushed
the
mh/IsInfiniteAbelianizationGroup
branch
from
d31fc78
to
ecb00ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #2287 +/- ##
==========================================
- Coverage 71.36% 71.35% -0.02%
==========================================
Files 480 480
Lines 253182 253182
==========================================
- Hits 180695 180666 -29
- Misses 72487 72516 +29
|
sebasguts
approved these changes
Mar 27, 2018
fingolfin
added
kind: enhancement
fingolfin
added
the
release notes: to be added
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some true methods (e.g. finite groups never have infinite abelianization; all but trivial free groups do have infinite abelianization), and some tests