trans: resolve GC bug Issue 2319 #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@james-d-mitchell Thanks! One minor request: If possible, I'd appreciate if you could please put "Resolves #XY" in the description body instead of (or in addition to) the subject line next time, so that the issues automatically gets closed when the PR is merged. I did it for you (well, or rather, for us, I guess ;-) this time. |
fingolfin
added
kind: bug
fingolfin
approved these changes
Mar 28, 2018
|
@ChrisJefferson actually, I don't think we should mark these GC fixes as "not for release notes". Instead, I'll add a single entry a la "fixed lots of potential GC related crashes", referencing the PRs |
|
@fingolfin Will do! |
|
Reminder to self re release notes: of course for fixes we backport, we should add them to the GAP 4.9 release notes, not 4.10 |
ChrisJefferson
approved these changes
Mar 28, 2018
|
Backported to stable-4.9 via ae5aa31 |
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2319