Tweak ShowImpliedFilters some more #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
kind: enhancement
Codecov Report
@@ Coverage Diff @@
## master #2340 +/- ##
==========================================
- Coverage 73.07% 73.07% -0.01%
==========================================
Files 480 480
Lines 246622 246628 +6
==========================================
+ Hits 180213 180217 +4
- Misses 66409 66411 +2
|
ThomasBreuer
approved these changes
Apr 2, 2018
fingolfin
force-pushed
the
mh/ShowImpliedFilters-again
branch
from
72549fb
to
82d5f0b
Compare
|
Fixed |
Now for "May imply with", we also hide implications which already follow from the other filter. For example, before: gap> ShowImpliedFilters(IsFinitelyGeneratedGroup); ... +IsNilpotentGroup IsSupersolvableGroup IsSolvableGroup IsPolycyclicGroup IsNilpotentByFinite After this change: gap> ShowImpliedFilters(IsFinitelyGeneratedGroup); ... +IsNilpotentGroup IsPolycyclicGroup Indeed, IsNilpotentGroup already implies IsSolvableGroup and IsNilpotentByFinite on its own.
fingolfin
force-pushed
the
mh/ShowImpliedFilters-again
branch
from
82d5f0b
to
9ccba17
Compare
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now for "May imply with", we also hide implications which already
follow from the other filter. For example, before:
After this change: