When tracing immediates, print location of definition #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
kind: enhancement
fingolfin
force-pushed
the
mh/trace-imm
branch
2 times, most recently
from
3428047
to
6d3fff5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2384 +/- ##
==========================================
- Coverage 73.69% 73.52% -0.18%
==========================================
Files 484 440 -44
Lines 245670 224026 -21644
==========================================
- Hits 181042 164707 -16335
+ Misses 64628 59319 -5309
|
For now, we print the location of the *method*. Ideally, we should instead track the location of the InstallImmediateMethod call. See also issue gap-system#2239. Before: gap> TraceImmediateMethods( ); gap> g:= Group( (1,2,3), (1,2) );; #I immediate: Size #I immediate: IsCyclic #I immediate: IsCommutative #I immediate: IsTrivial After: gap> TraceImmediateMethods( ); gap> g:= Group( (1,2,3), (1,2) );; #I RunImmediateMethods #I immediate: Size at GAPROOT/lib/coll.gi:174 #I immediate: IsCyclic at GAPROOT/lib/grp.gi:34 #I immediate: IsCommutative at GAPROOT/lib/magma.gi:190 #I immediate: IsTrivial at GAPROOT/lib/magma.gi:124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tracing immediates, print location of definition
For now, we print the location of the method. Ideally, we should
instead track the location of the InstallImmdiateMethod call. See also
issue #2239.
Before:
After: