Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iterating over an empty cartesian product #2421

Merged
merged 1 commit into from
May 2, 2018
Merged

Fix iterating over an empty cartesian product #2421

merged 1 commit into from
May 2, 2018

Conversation

fingolfin
Copy link
Member

Fixes #2420

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them labels Apr 30, 2018
@codecov
Copy link

codecov bot commented Apr 30, 2018 •
edited
Loading

Codecov Report

Merging #2421 into master will increase coverage by <.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #2421      +/-   ##
==========================================
+ Coverage   73.88%   73.88%   +<.01%     
==========================================
  Files         484      484              
  Lines      245462   245465       +3     
==========================================
+ Hits       181368   181374       +6     
+ Misses      64094    64091       -3
Impacted Files Coverage Δ
lib/combinat.gi 66.75% <80%> (+0.4%) ⬆️
hpcgap/lib/hpc/stdtasks.g 63.93% <0%> (-0.26%) ⬇️
src/objset.c 84.59% <0%> (-0.23%) ⬇️

@fingolfin
Copy link
Member Author

Perhaps this would be a good candidate for backporting to GAP 4.9.2 - the fix is obvious and self-contained, with very little chance of causing regressions.

@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.2 milestone May 1, 2018
@fingolfin fingolfin merged commit ddae7f8 into gap-system:master May 2, 2018
@fingolfin fingolfin deleted the mh/fix-IteratorOfCartesianProduct branch May 2, 2018 16:06
@fingolfin
Copy link
Member Author

Backported in 463f45f

@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexandr-konovalov olexandr-konovalov olexandr-konovalov approved these changes

@ssiccha ssiccha ssiccha approved these changes

Assignees
No one assigned
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
GAP 4.9.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fingolfin @olexandr-konovalov @ssiccha