Improve and test support for custom functions #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
kind: enhancement
ThomasBreuer
approved these changes
May 1, 2018
There was a problem hiding this comment.
This is an improvement.
Concerning the change in lib/function.g, also the documentation for some of the operations could be corrected (replace <Func Name=... by <Oper Name=..., replace #F by #O, remove the #T lines that state that a function should better be an operation).
Concerning the new tests whether methods for the operations can be installed, what about tests that the installed methods get called?
* NamesLocalVariablesFunction actually is a kernel operation, mark it as such * fix a crash caused by infinite recursion when trying to display a function which is not a `T_FUNCTION` * add tests for installing custom methods for NameFunction, NamesLocalVariablesFunction, and NumberArgumentsFunction
Codecov Report
@@ Coverage Diff @@
## master #2427 +/- ##
==========================================
+ Coverage 73.88% 73.89% +<.01%
==========================================
Files 484 484
Lines 245465 245465
==========================================
+ Hits 181371 181375 +4
+ Misses 64094 64090 -4
|
|
@ThomasBreuer good remarks, thanks, hopefully all addressed now (also the test failure in HPC-GAP) |
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is not a
T_FUNCTIONNamesLocalVariablesFunction, and NumberArgumentsFunction