Teach BuildPackages.sh how to build simpcomp #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: build system
topic: packages
... by working around missing executable bits, and moving the bistellar executable into a place where GAP can find it
Codecov Report
@@ Coverage Diff @@
## master #2475 +/- ##
==========================================
- Coverage 74.06% 74.06% -0.01%
==========================================
Files 484 484
Lines 245514 245514
==========================================
- Hits 181842 181839 -3
- Misses 63672 63675 +3
|
olexandr-konovalov
approved these changes
May 17, 2018
|
Backported to GAP 4.9 via 28592e8 |
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by working around missing executable bits, and moving the bistellar executable into a place where GAP can find it
I would suggest backporting this to stable-4.9. Even if they release a version with fixed, this patch is still useful, as it prevents the script from passing
--with-gaprootto the simpcompconfigure, which does not support it.