Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageSource should show local file #2606

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

frankluebeck
Copy link
Member

So far, we assumed in PageSource that if FILENAME_FUNC returns a string not
starting with '/' that the pathname was relative to a GAP root. This is not
true if a function was read from a file relative to GAPs current directory.

Remark: It would be good to store a full path with function read from a
local file.

So far, we assumed in PageSource that if FILENAME_FUNC returns a string not
starting with '/' that the pathname was relative to a GAP root. This is not
true if a function was read from a file relative to GAPs current directory.

Remark: It would be good to store a full path with function read from a
local file.
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #2606 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2606      +/-   ##
==========================================
- Coverage    74.8%   74.79%   -0.01%     
==========================================
  Files         479      479              
  Lines      242243   242245       +2     
==========================================
- Hits       181198   181195       -3     
- Misses      61045    61050       +5
Impacted Files Coverage Δ
lib/methwhy.g 49.58% <0%> (-0.42%) ⬇️
hpcgap/lib/hpc/stdtasks.g 63.42% <0%> (-0.77%) ⬇️

Copy link
Contributor

@ssiccha ssiccha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds and looks sensible to me.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements labels Jul 5, 2018
@fingolfin fingolfin merged commit f37d802 into gap-system:master Jul 5, 2018
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants