-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the generators in OmegaZero(2m+1,2^k) #2613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just have two minor (and optional) remarks.
@@ -131,7 +131,7 @@ Error, <subfield> must be a prime or a finite field | |||
|
|||
# | |||
gap> Omega(3,2); | |||
Omega(0,3,2) | |||
GO(0,3,2) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
x2:= IdentityMat( d, f ); | ||
x2[ m+1 ][m]:= o; | ||
x2[ m+2 ][m]:= o; | ||
x:= x1 * x2; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
For odd d and even q, the generators for the matrix groups Omega(0,d,q) from the Rylands/Taylor paper were not correct; one would have to transpose the matrices in order to get a group that respects a form as required. Instead of transposing the generators, we delegate to `SO`, which has the advantage to reduce the possible confusion about the choice of different forms for related orthogonal groups.
26a7117
to
f00afa9
Compare
LGTM! |
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
+ Coverage 74.8% 74.8% +<.01%
==========================================
Files 479 479
Lines 242251 242238 -13
==========================================
- Hits 181206 181198 -8
+ Misses 61045 61040 -5
|
For odd d and even q,
the generators for the matrix groups Omega(0,d,q)
from the Rylands/Taylor paper were not correct;
one would have to transpose the matrices in order to get
a group that respects a form as required.
Instead of transposing the generators, we delegate to
SO
,which has the advantage to reduce the possible confusion
about the choice of different forms for related orthogonal groups.
Resolves #2576