Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: fix RandomIntegerMT on 64 bit big endian #2638

Merged
merged 1 commit into from Jul 11, 2018
Merged

kernel: fix RandomIntegerMT on 64 bit big endian #2638

merged 1 commit into from Jul 11, 2018

Conversation

fingolfin
Copy link
Member

Fixes #2292

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them topic: kernel labels Jul 10, 2018
@fingolfin fingolfin requested a review from dimpase July 10, 2018 20:36
@codecov
Copy link

codecov bot commented Jul 11, 2018 •
edited

Codecov Report

Merging #2638 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2638      +/-   ##
==========================================
- Coverage   75.12%   75.12%   -0.01%     
==========================================
  Files         478      478              
  Lines      242226   242225       -1     
==========================================
- Hits       181965   181961       -4     
- Misses      60261    60264       +3
Impacted Files Coverage Δ
src/integer.c 92.28% <100%> (-0.01%) ⬇️
src/iostream.c 62.35% <0%> (-1.15%) ⬇️
src/hpc/threadapi.c 43.48% <0%> (-0.11%) ⬇️
hpcgap/lib/hpc/stdtasks.g 64.7% <0%> (+0.25%) ⬆️

@fingolfin
Copy link
Member Author

@dimpase can you please confirm that this fixes the issue for you?

dimpase
dimpase approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tests fine on SPARC64

@dimpase
Copy link
Member

dimpase commented Jul 11, 2018

Thanks for fixing this stuff!

@fingolfin fingolfin merged commit 4a3af77 into gap-system:master Jul 11, 2018
@fingolfin fingolfin deleted the mh/big-endian-random branch July 11, 2018 22:53
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

Assignees
No one assigned
Labels
kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fingolfin @dimpase