Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty command line arguments #2665

Merged
merged 1 commit into from
Jul 28, 2018

Conversation

ChrisJefferson
Copy link
Contributor

Empty arguments are just ignored, which follows what GAP does with
other arguments it does not understand.

Fixes #2662

Empty arguments are just ignored, which follows what GAP does with
other arguments it does not understand.
@ChrisJefferson ChrisJefferson added kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) topic: kernel labels Jul 26, 2018
@codecov
Copy link

codecov bot commented Jul 26, 2018

Codecov Report

Merging #2665 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2665      +/-   ##
==========================================
+ Coverage   75.19%   75.19%   +<.01%     
==========================================
  Files         478      478              
  Lines      242242   242244       +2     
==========================================
+ Hits       182144   182150       +6     
+ Misses      60098    60094       -4
Impacted Files Coverage Δ
lib/system.g 66.97% <66.66%> (-0.16%) ⬇️
hpcgap/lib/hpc/stdtasks.g 64.96% <0%> (+1.27%) ⬆️

@markuspf markuspf merged commit 68303b9 into gap-system:master Jul 28, 2018
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jul 31, 2018
@ChrisJefferson ChrisJefferson deleted the fix-empty-arg branch August 20, 2018 10:05
@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants