kernel: fix SaveWorkspace to return false in case of an error, and true only if successful #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we fail to open the output file (e.g. because the target location does not exist or is not writeable for some other reason), then return false instead of true. Also, terminate all error messages with a new line. Fixes gap-system#2673
fingolfin
added
kind: bug
Codecov Report
@@ Coverage Diff @@
## master #2674 +/- ##
==========================================
- Coverage 75.41% 75.41% -0.01%
==========================================
Files 478 478
Lines 241578 241580 +2
==========================================
Hits 182192 182192
- Misses 59386 59388 +2
|
stevelinton
approved these changes
Aug 1, 2018
ChrisJefferson
approved these changes
Aug 1, 2018
fingolfin
changed the title
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we fail to open the output file (e.g. because the target location does not
exist or is not writeable for some other reason), then return false instead of
true.
Also, terminate all error messages with a new line.
Fixes #2673