Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the Julia GC integration #2688

Merged
merged 8 commits into from
Sep 7, 2018
Merged

Conversation

rbehrends
Copy link
Contributor

This brings the implementation in line with the most recent API changes for the Julia GC extensions and cleans up some code.

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: kernel release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Aug 9, 2018
@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #2688 into master will increase coverage by 0.12%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #2688      +/-   ##
==========================================
+ Coverage   75.75%   75.87%   +0.12%     
==========================================
  Files         478      481       +3     
  Lines      241495   241314     -181     
==========================================
+ Hits       182940   183094     +154     
+ Misses      58555    58220     -335
Impacted Files Coverage Δ
src/gasman.h 95.12% <ø> (+0.25%) ⬆️
src/gap.c 84.42% <0%> (-0.83%) ⬇️
src/weakptr.c 97.72% <100%> (-0.01%) ⬇️
lib/init.g 71.35% <40%> (-0.42%) ⬇️
src/io.c 59.9% <0%> (-1.13%) ⬇️
src/calls.c 93.58% <0%> (-1.07%) ⬇️
src/objcftl.c 23.46% <0%> (-0.85%) ⬇️
hpcgap/lib/hpc/stdtasks.g 63.42% <0%> (-0.77%) ⬇️
lib/oper.g 80.96% <0%> (-0.39%) ⬇️
... and 64 more

@fingolfin fingolfin added the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Aug 9, 2018
@fingolfin
Copy link
Member

Since those Julia changes are not yet quite stable, let's wait with merging this for now.

For the status of the Julia side of things, see here: JuliaLang/julia#28368

@fingolfin
Copy link
Member

Memo to @rbehrends and myself: we should also modify init.g to print something like with Julia GC or even with Julia 1.0 or so (and then export from the kernel JULIA_VERSION, just like GMP_VERSION is exported).

@fingolfin fingolfin removed the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Sep 7, 2018
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem likely to be ready for the "final" Julia GC extension interface (although that still hasn't been merged). For user convenience, it'd be nice to still get this into GAP 4.10. Since the code in here is disabled for non-Julia users, that should cause no issues.

@fingolfin fingolfin changed the title WIP: Updates to the Julia GC integration. Updates to the Julia GC integration Sep 7, 2018
@fingolfin fingolfin merged commit d48bd64 into gap-system:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants