kernel: reject invalid AND-filters

[fingolfin]

This rejects invalid AND-filters like this:

gap> Center and IsAssociative;
<Filter "<<and-filter>>">

This contains PR #2755 and thus further extends the work begun in PR PR #2732. However, it should not be merged until fixed versions of packages relying on the old buggy behavior are part of the distribution. Specifically, these packages (they all already merged a fix):

• MatricesForHomalg
• qpa
• xmodalg

Alternatively, we could skip merging PR #2755, and directly merge a (squashed) version of this PR. That depends a bit on whether we decide to merge PR #2755 for GAP 4.10 or not, and/or on how quick fixed releases of these packages appear.

[codecov]

Codecov Report

Merging #2756 into master will decrease coverage by <.01%.
The diff coverage is 39.47%.

@@            Coverage Diff             @@
##           master    #2756      +/-   ##
==========================================
- Coverage   83.77%   83.77%   -0.01%     
==========================================
  Files         681      681              
  Lines      346620   346651      +31     
==========================================
+ Hits       290368   290392      +24     
- Misses      56252    56259       +7

Impacted Files	Coverage Δ
src/opers.h	100% <ø> (ø)	⬆️
src/error.c	77.77% <0%> (-1.9%)	⬇️
src/exprs.c	97.59% <100%> (+1.01%)	⬆️
src/compiler.c	88.37% <100%> (+0.1%)	⬆️
src/intrprtr.c	98.83% <100%> (-0.01%)	⬇️
src/c_oper1.c	93.55% <11.11%> (-0.15%)	⬇️
src/hpc/c_oper1.c	92.74% <16.66%> (-0.05%)	⬇️
src/c_type1.c	84.85% <33.33%> (-0.09%)	⬇️
src/hpc/c_type1.c	85.08% <50%> (-0.05%)	⬇️
src/opers.c	94.8% <75%> (-0.05%)	⬇️
... and 5 more

[olexandr-konovalov]

I cross-referenced this in #2804 under "PRs blocked by packages".

[sunnyquiver]

The QPA-team has now created a new release 1.28 incorporating the fix.

[olexandr-konovalov]

QPS: @sunnyquiver thanks, I see gap-packages/qpa#16 merged. There was another problem with the new release of QPA, so waiting now for the next one.

XModAlg: ticked the box, gap-packages/xmodalg#25 is now in version 1.17 from 30/08/2018.

homalg: ticked the box for homalg-project/homalg_project#205 merged in MatricesForHomalg and released in version 2018.08.25 dated 25/08/2018.

[olexandr-konovalov]

@fingolfin all three packages are now in bootstrapping package archives - please rebase, and I hope we will be able to merge this after the test (hope no other packages did this in the meantime).

[olexandr-konovalov]

Looks good to me. Checked package loading log https://travis-ci.org/gap-system/gap/jobs/440558613 - this PR does not trigger any errors when packages are loaded.

Will this consist of three commits, or two of them will be glued together?

[fingolfin]

I'll squash them, and also look into fixing the compiler variant.