Clarify MemoizePosIntFunction documentation #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clarify the documentation, and add a test case for when the invalidInputHandler returns without a value
fingolfin
added
topic: documentation
Codecov Report
@@ Coverage Diff @@
## master #2798 +/- ##
==========================================
+ Coverage 75.88% 75.88% +<.01%
==========================================
Files 481 481
Lines 241344 241344
==========================================
+ Hits 183135 183140 +5
+ Misses 58209 58204 -5
|
ChrisJefferson
approved these changes
Sep 12, 2018
|
Just a general comment, as we have branched stable-4.10, this PR (and all other PRs) aren't going to get merged into 4.10 unless a label is added. While this PR is good, I don't think it needs to be in 4.10. |
|
I fully agree. I'd only consider PRs which fix issues for backporting; right now, I think only PR #2779 would qualify, but that one is not mergeable right now, @ThomasBreuer would need to rebase it first. |
fingolfin
changed the title
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clarify the documentation, and add a test case for when the
invalidInputHandler returns without a value
This contains part of the (now closed) PR #2600.