Fix GreensXClasses for a Green's class #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
added
kind: enhancement
Codecov Report
@@ Coverage Diff @@
## master #2830 +/- ##
==========================================
+ Coverage 76.05% 76.05% +<.01%
==========================================
Files 480 480
Lines 241022 241022
==========================================
+ Hits 183310 183311 +1
+ Misses 57712 57711 -1
|
james-d-mitchell
approved these changes
Sep 19, 2018
lib/semirel.gd
Outdated
| ## <Attr Name="GreensLClasses" Arg='S'/> | ||
| ## <Attr Name="GreensHClasses" Arg='S'/> | ||
| ## <Attr Name="GreensJClasses" Arg='S'/> | ||
| ## <Attr Name="GreensDClasses" Arg='S'/> |
There was a problem hiding this comment.
I'm not sure the rationale behind using " and ' here?
lib/semirel.gi
Outdated
| @@ -720,13 +720,13 @@ function(semi) | |||
| end); | |||
|
|
|||
| InstallOtherMethod(GreensHClasses, "for a Green's Class", true, [IsGreensDClass], 0, | |||
There was a problem hiding this comment.
It might be better to DeclareAttribute("GreensHClasses", IsGreensDClass); and drop the Other here, but maybe there is some reason I don't know for doing it this way.
Also I believe the true and the 0 are redundant, and could be removed.
Previously, there was undocumented and broken support for computing the GreensXClasses of a Green's class. I have now fixed and documented this code.
wilfwilson
force-pushed
the
fix-greens-classes-for-a-greens-class
branch
from
7285f12
to
8d04adf
Compare
|
Thank you for reviewing @james-d-mitchell |
fingolfin
approved these changes
Sep 19, 2018
|
@fingolfin: I am happy with it as-is. @james-d-mitchell revoked his write access to GAP, and I never had write access, so it'll have to be merged by someone else. |
fingolfin
added
the
kind: bug
wilfwilson
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was undocumented and broken support for computing the
GreensXClasses(whereXis in{H, L, R}contained in a particular type of Green's class. This arose from the following issue on the Semigroups package issue tracker: semigroups/Semigroups#413I have now made a simple fix, and documented this behaviour (it doesn't have brilliant performance, but it is better than an error).