Extend obsolete to support multiple levels #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also issue #1456 |
olexandr-konovalov
approved these changes
Oct 16, 2018
fingolfin
requested changes
Oct 18, 2018
ChrisJefferson
force-pushed
the
obsolete
branch
from
0b9c72c
to
3172925
Compare
Codecov Report
@@ Coverage Diff @@
## master #2923 +/- ##
==========================================
- Coverage 83.8% 75.64% -8.17%
==========================================
Files 681 625 -56
Lines 346747 312674 -34073
==========================================
- Hits 290591 236518 -54073
- Misses 56156 76156 +20000
|
|
Hopefully all @fingolfin 's comments addressed, once tests cycle (adding a test did find a bug, where only printing the message once meant the message was never shown if the function had been called when the Info level was too low to show it). |
fingolfin
approved these changes
Oct 19, 2018
|
The manual tests fail. |
ChrisJefferson
force-pushed
the
obsolete
branch
from
766fc3f
to
6708c58
Compare
Obsolete warnings of level 1 will be displayed by default. Obsolete declarations taken an optional argument to set obsolete level (which defaults to 2). Obsolete warnings are now only printed once per obsolete function.
ChrisJefferson
force-pushed
the
obsolete
branch
from
6708c58
to
b575234
Compare
olexandr-konovalov
added
the
release notes: to be added
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One problem with the way we currently handle 'obsolete' is that normal users of GAP will never see an obsolete warning, until we delete the function (as they don't tend to increase InfoObsolete, or run with
-O).This extends 'obsolete' into two levels, 1 and 2. Level 1 messages are always printed, level 2 messages have to be explicitly enabled.
The -O option still disables any obsolete functions from being used at all.
My long-term plan is that we would put obsolete messages in a major release at level 1 before removing them, so users would actually see a warning, and have the chance to fix their code.
If changing how InfoObsolete works upsets anyone, we could add a different variable (
InfoObsoleteSoon?) which displayed messages about things we will delete in the future.