Add back ViewObj method for generic fields
#2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Oct 22, 2018
This method had been lost in 2012 (see Commit v4.6.0) when a `ViewString` method had replaced it. Note that other `ViewObj` methods for the objects in question are applicable that have a higher rank than the delegation to `ViewString`. The same happens for many objects, but for the moment I want to fix the behavior for fields. (This could have been noticed in `tst/testbugfix/2012-08-14-t00271.tst`.)
ThomasBreuer
force-pushed
the
TB_ViewObj_for_fields
branch
from
228314f
to
55b1aec
Compare
Codecov Report
@@ Coverage Diff @@
## master #2936 +/- ##
==========================================
+ Coverage 83.79% 83.8% +<.01%
==========================================
Files 680 681 +1
Lines 346451 346747 +296
==========================================
+ Hits 290310 290591 +281
- Misses 56141 56156 +15
|
PaulaHaehndel
added
release notes: to be added
fingolfin
changed the title
ViewObj method for generic fieldsViewObj method for generic fields
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method had been lost in 2012 (see Commit v4.6.0)
when a
ViewStringmethod had replaced it.Note that other
ViewObjmethods for the objects in question areapplicable that have a higher rank than the delegation to
ViewString.The same happens for many objects, but for the moment I want to fix
the behavior for fields.
(This could have been noticed in
tst/testbugfix/2012-08-14-t00271.tst.)