document what a 'small integer' is; make "need positive small int" errors consistent; avoid 32/64 bit specific error messages #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use `IS_POS_INTOBJ` is possible * consistently refer to "positive small integer", where "small integer" is understood to have a special meaning
fingolfin
added
topic: documentation
fingolfin
force-pushed
the
mh/smallint
branch
from
821d91a
to
2f149b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2946 +/- ##
==========================================
- Coverage 83.8% 75.67% -8.13%
==========================================
Files 681 625 -56
Lines 346416 312462 -33954
==========================================
- Hits 290303 236453 -53850
- Misses 56113 76009 +19896
|
These were wrong since at least 1997...
ChrisJefferson
approved these changes
Oct 28, 2018
There was a problem hiding this comment.
This looks great.
This PR is so long I wanted to find a comment, just to prove I've read it all, but I didn't find one :)
I thought about this causing package failures, but really packages probably should be in general testing for errors in library code (although there might be some good exceptions of course).
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.