Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that PermutationGModule works not just for finite fields #2953

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Oct 29, 2018

PermutationGModule works pefectly well with any field.

PermutationGModule works pefectly well with any field.
@ChrisJefferson
Copy link
Contributor

Would it be possible to add a test to make sure these work (just to make sure it's intentional they work, as opposed to a missing test to forbid them)?

@dimpase
Copy link
Member Author

dimpase commented Oct 29, 2018

But why? There should not have been any finiteness test in the 1st place...

In fact there used to be a test for finiteness of the field (there and in few other functions from MTX), completely unnecessary, and I had to remove it in computations I did that time.
Certainly MTX needs field to be finite to do MTXing, but it does not need it for things like this, or constructing the tensor product, say.

So it was an issue on an old tracker about it, or even before it existed, and someone took my patches and applied them.

Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial documentation change that has no side-effects and should not require the author to implement test-cases.

@ChrisJefferson ChrisJefferson merged commit 3336f95 into gap-system:master Oct 31, 2018
@PaulaHaehndel PaulaHaehndel changed the title a doc typo Document that PermutationGModule works not just for finite fields Apr 15, 2019
@PaulaHaehndel PaulaHaehndel added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Apr 15, 2019
@PaulaHaehndel PaulaHaehndel added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Apr 23, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants