Improve some kernel error messages #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: to be added
|
Picky, I don't really like the messages
EDIT: I'm happy with |
src/error.h
Outdated
| */ | ||
| #define RequireSmallInt(funcname, op, argname) \ | ||
| RequireArgumentCondition(funcname, op, argname, IS_INTOBJ(op), \ | ||
| "must be an integer") |
There was a problem hiding this comment.
Should the refer to the "smallness" of the required integer somehow?
There was a problem hiding this comment.
Ouch, indeed, that's a copy&past mistake. I'll change it to "must be a small integer"
|
How about |
fingolfin
force-pushed
the
mh/error-check
branch
from
28e53d9
to
48b352c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2955 +/- ##
==========================================
+ Coverage 83.79% 83.81% +0.01%
==========================================
Files 682 682
Lines 346236 346046 -190
==========================================
- Hits 290135 290043 -92
+ Misses 56101 56003 -98
|
This changes error messages like
Error, E: <n> must be a positive small integer (not a integer)
Error, OnTuples: <tuple> must be a small list (not a boolean or fail)
to something like this:
Error, E: <n> must be a positive small integer (not the integer 0)
Error, OnTuples: <tuple> must be a small list (not fail)
Specifically, small integers are printed as part of the error message; and for
the three T_BOOL values true, false and fail, we print them, too.
fingolfin
force-pushed
the
mh/error-check
branch
from
48b352c
to
419b750
Compare
markuspf
approved these changes
Nov 1, 2018
ChrisJefferson
approved these changes
Nov 1, 2018
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work begun in PR #2947 and implements the change I promised there: Instead of "(not a integer)" we now say for example "(not the integer 5)".
Also adds and uses
RequireStringRep,RequireInt,RequireSmallInt