Remove confusing error message #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
requested changes
Nov 8, 2018
When calling Group with a domain as argument, GAP raised the error "no longer supported ...", which was not helpful (what is no longer supported?). We just remove this error condition which will lead to a usage message for the function Group to be printed.
markuspf
force-pushed
the
remove-no-longer-supported
branch
from
7d524cc
to
4c33681
Compare
Codecov Report
@@ Coverage Diff @@
## master #2974 +/- ##
==========================================
+ Coverage 83.81% 83.81% +<.01%
==========================================
Files 682 682
Lines 345976 346008 +32
==========================================
+ Hits 289965 289999 +34
+ Misses 56011 56009 -2
|
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
Group()with a domain as argument, GAP raised the error"no longer supported ...", which was not helpful (what is no longer supported?).
We just remove this error condition which will lead to a usage message for the
function
Group()to be printed.