Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use robust rank for generic SemidirectProduct method; function fields are fields; tweak a LocationFunc test #2977

Merged
merged 3 commits into from Nov 9, 2018
Merged

Use robust rank for generic SemidirectProduct method; function fields are fields; tweak a LocationFunc test #2977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fdecc2
Use robust rank for generic SemidirectProduct method
fingolfin Nov 8, 2018
fd81552
Function fields are fields
fingolfin Nov 8, 2018
3c9889b
Tweak a LocationFunc test
fingolfin Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/gprd.gi
View file
Open in desktop
Expand Up @@ -1080,7 +1080,7 @@ end);
InstallMethod( SemidirectProduct,"different representations",true,
[ IsGroup and IsFinite, IsGroupHomomorphism, IsGroup and IsFinite],
# don't be higher than specific perm/pc methods
-20,
{} -> 2*(RankFilter(IsGroup) - RankFilter(IsGroup and IsFinite)),
function( G, aut, N )
local giso,niso,P,gens,a,Go,No,i;
Go:=G;
Expand Down
2 changes: 1 addition & 1 deletion lib/ringpoly.gd
View file
Open in desktop
Expand Up @@ -42,7 +42,7 @@ DeclareCategory( "IsPolynomialRing", IsRing );
## </ManSection>
## <#/GAPDoc>
##
DeclareCategory("IsFunctionField",IsRing);
DeclareCategory("IsFunctionField",IsField);

#############################################################################
##
Expand Down
5 changes: 0 additions & 5 deletions lib/ringpoly.gi
View file
Open in desktop
Expand Up @@ -667,11 +667,6 @@ function(r,n)
type := IsFunctionField and IsAttributeStoringRep and IsLeftModule
and IsAlgebraWithOne;

# If the coefficients form an integral ring, then the function field is also a field
if HasIsIntegralRing(r) and IsIntegralRing(r) then
type:= type and IsField;
fi;

fcfl := Objectify(NewType(CollectionsFamily(rfun),type),rec());;

# The function field is commutative if and only if the coefficient ring is.
Expand Down
4 changes: 2 additions & 2 deletions tst/testinstall/opers/LocationFunc.tst
View file
Open in desktop
Expand Up @@ -6,8 +6,8 @@ gap> LocationFunc(f);
"stream:1"

# Library function
gap> LocationFunc(OnQuit);
"GAPROOT/lib/error.g:32"
gap> LocationFunc(Where);
"GAPROOT/lib/error.g:79"

# GAP function which was compiled to C code by gac
gap> LocationFunc(INSTALL_METHOD_FLAGS);
Expand Down