Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some integer related functions to libgap API #2998

Merged
merged 2 commits into from
Nov 15, 2018
Merged

Add some integer related functions to libgap API #2998

merged 2 commits into from
Nov 15, 2018

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin fingolfin added topic: kernel topic: libgap things related to libgap labels Nov 14, 2018
sebasguts
sebasguts approved these changes Nov 14, 2018
View reviewed changes
src/libgap-api.c Outdated Show resolved Hide resolved
src/libgap-api.h Outdated Show resolved Hide resolved
@sebasguts @fingolfin
Fix typo GAP_IsLargInt -> GAP_IsLargeInt
aad523a 
Co-Authored-By: fingolfin <max@quendi.de>
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #2998 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2998      +/-   ##
=========================================
- Coverage   85.13%   85.1%   -0.04%     
=========================================
  Files         110     110              
  Lines       56960   56979      +19     
=========================================
- Hits        48491   48490       -1     
- Misses       8469    8489      +20
Impacted Files Coverage Δ
src/libgap-api.c 22.72% <0%> (-4.45%) ⬇️
src/iostream.c 62.35% <0%> (-1.15%) ⬇️
src/hpc/threadapi.c 45.15% <0%> (+0.13%) ⬆️

@markuspf markuspf merged commit 5841214 into gap-system:master Nov 15, 2018
@fingolfin fingolfin deleted the mh/libgap-ints branch November 15, 2018 11:13
@fingolfin fingolfin added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Apr 15, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebasguts sebasguts sebasguts approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

@markuspf markuspf Awaiting requested review from markuspf

Assignees
No one assigned
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel topic: libgap things related to libgap
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fingolfin @sebasguts @markuspf @olexandr-konovalov