buildsys: always generate sysinfo.gap #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By accident, sysinfo.gap was only generated if the "compatibility mode" of the build system was enabled. This is currently still on by default, but I'd like to change that in a future release of GAP. This is a first step towards this goal.
fingolfin
added
kind: bug
Codecov Report
@@ Coverage Diff @@
## master #3042 +/- ##
==========================================
+ Coverage 83.78% 83.78% +<.01%
==========================================
Files 685 685
Lines 343368 343368
==========================================
+ Hits 287686 287693 +7
+ Misses 55682 55675 -7
|
fingolfin
requested review from
ChrisJefferson,
olexandr-konovalov,
sebasguts and
markuspf
markuspf
approved these changes
Nov 22, 2018
sebasguts
approved these changes
Nov 22, 2018
olexandr-konovalov
added
backport-to-4.10-DONE
release notes: to be added
|
Backported in aa080f1 |
olexandr-konovalov
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By accident, sysinfo.gap was only generated if the "compatibility mode"
of the build system was enabled. This is currently still on by default,
but I'd like to change that in a future release of GAP. This is a first
step towards this goal.
This PR was actually motivated by the build issue with
NormalizInterfacein @stevelinton's PR #2997 -- while looking at it, I noticed that compat mode still is on, and I never formulated a roadmap for phasing it out.I'd like to backport this minor change to GAP 4.10, if nobody minds.