ENHANCE: Avoid memory issues in solvable conjugacy classes routine. #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
added
topic: performance
Codecov Report
@@ Coverage Diff @@
## master #3078 +/- ##
=========================================
Coverage ? 83.58%
=========================================
Files ? 686
Lines ? 336845
Branches ? 0
=========================================
Hits ? 281536
Misses ? 55309
Partials ? 0
|
hulpke
changed the title
fingolfin
reviewed
Dec 4, 2018
hulpke
force-pushed
the
additions
branch
2 times, most recently
from
5c1b530
to
88afc74
Compare
hulpke
removed
the
do not merge
ChrisJefferson
approved these changes
Dec 18, 2018
fingolfin
approved these changes
Dec 18, 2018
lib/claspcgs.gi
Outdated
| @@ -325,6 +325,7 @@ local classes, # classes to be constructed, the result | |||
| depthlev, # depth at which N starts | |||
| one,zero, | |||
| vec, | |||
| dict, | |||
There was a problem hiding this comment.
Minor nitpick: tabs vs. spaces...
Reduce assertion level in test, as the many tests otherwise make it unusable
Use option to enforce longer blist, as its used anyhow.
This avoids enumerating a large vector space, but is not always possible.
wilfwilson
added
kind: enhancement
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases of many classes being created by acting on a large vector space, there can be significant memory churning by recreating dictionaries and orbits. Avoid doing so.
Changing dictionary limits also pointed out some shortcomings with small matrix groups over large fields.
Finally, try to reduce the size of the vector space, if possible.